Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2583#discussion_r172011690
--- Diff: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java ---
@@ -173,4 +176,23 @@ public void
isZkAuthenticationConfiguredStormServerWithPropertyTest() {
}
}
}
+
+ @Test
+ public void testMapDiff() {
+ Map<String, Object> map0 = ImmutableMap.of();
+ Assert.assertTrue("case0", Utils.confMapDiff(map0, map0));
+ Map<String, Object> map1 = ImmutableMap.of("k0", ImmutableList.of(1L,
2L), "k1", ImmutableSet.of('s', 'f'),
+ "k2", "as");
+ Assert.assertTrue("case1", Utils.confMapDiff(map1, map1));
+ Map<String, Object> map2 = ImmutableMap.of("k0", ImmutableList.of(1L,
2L), "k1", ImmutableSet.of('s', 'f'),
+ "k2", "as");
+ Assert.assertTrue("case2", Utils.confMapDiff(map2, map2));
--- End diff --
Nit: This test is covered by line 186
---
