[GitHub] storm pull request #2583: STORM-2649 More detailed check of config serializa...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2583#discussion_r172011663
  
    --- Diff: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java ---
    @@ -173,4 +176,23 @@ public void 
isZkAuthenticationConfiguredStormServerWithPropertyTest() {
                 }
             }
         }
    +
    +    @Test
    +    public void testMapDiff() {
    --- End diff --
    
    Nitpick: Consider splitting this into multiple small tests each checking 
one thing


---