Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2583#discussion_r172667597
  
    --- Diff: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java ---
    @@ -173,4 +176,49 @@ public void 
isZkAuthenticationConfiguredStormServerWithPropertyTest() {
                 }
             }
         }
    +
    +    @Test
    --- End diff --
    
    Can we have some tests for isValidConf in addition to checkMapEquality?


---

Reply via email to