Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2588#discussion_r173635720
  
    --- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/format/EventHubMessageDataScheme.java
 ---
    @@ -0,0 +1,54 @@
    
+/*******************************************************************************
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + 
*******************************************************************************/
    +package org.apache.storm.eventhubs.format;
    +
    +import java.util.LinkedList;
    +import java.util.List;
    +
    +import org.apache.storm.eventhubs.core.EventHubMessage;
    +import org.apache.storm.eventhubs.core.FieldConstants;
    +import org.apache.storm.tuple.Fields;
    +
    +import com.microsoft.azure.eventhubs.EventData;
    +
    +/**
    + * This scheme constructs an {@link EventHubMessage} object from the 
received
    --- End diff --
    
    The class doesn't construct an EventHubMessage though?


---

Reply via email to