Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2588#discussion_r173635150
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/Partitions.java
---
@@ -25,17 +25,18 @@
* Represents all EventHub partitions a spout is receiving messages from.
*/
public class Partitions implements Serializable {
- private static final long serialVersionUID = 1L;
- private List<Partition> partitionList;
- public Partitions() {
- partitionList = new ArrayList<Partition>();
- }
-
- public void addPartition(Partition partition) {
- partitionList.add(partition);
- }
-
- public List<Partition> getPartitions() {
- return partitionList;
- }
+ private static final long serialVersionUID = 1L;
+ private List<Partition> partitionList;
--- End diff --
Why does it make sense to have this class, rather than just using the
`List<Partition>` directly?
---
