Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2588#discussion_r173634426
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/core/IEventHubReceiver.java
---
@@ -0,0 +1,78 @@
+/*******************************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+
*******************************************************************************/
+package org.apache.storm.eventhubs.core;
+
+import java.io.IOException;
+import java.util.Map;
+
+import com.microsoft.azure.eventhubs.EventData;
+import com.microsoft.azure.eventhubs.EventHubException;
+
+/**
+ * EventHub based Receiver contracts
+ *
+ */
+public interface IEventHubReceiver {
+
+ /**
+ * Open / Establish connection to Eventhub given filters. The partition
to
+ * receive events from will be specified in an implementation specific
way.
+ *
+ * @param filter
+ * offset or timestamp based filter
+ * @throws EventHubException
+ * @see {@link IEventFilter} {@link OffsetFilter} {@link
TimestampFilter}
+ */
+ void open(IEventFilter filter) throws IOException, EventHubException ;
+
+ /**
+ * Cleanup and close connection to Eventhub
+ */
+ void close();
+
+ /**
+ * Check if connection to eventhub is active
+ *
+ * @return
--- End diff --
Just remove this if you're not writing anything here, since it's just noise
at that point. Same for the `@throws` above.
---
