Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2714#discussion_r195243886
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -73,6 +130,12 @@ private static void
startMetricsReporter(PreparableReporter reporter, Map<String
}
private static <T extends Metric> T register(String name, T metric) {
+ if (source != null && !name.startsWith(source)) {
--- End diff --
I think it would be better to register with a Daemon type enum and metric
name. This would allows metrics that are daemon specific and general to work
for a given daemon.
---
