Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2714#discussion_r195246920
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -73,6 +130,12 @@ private static void
startMetricsReporter(PreparableReporter reporter, Map<String
}
private static <T extends Metric> T register(String name, T metric) {
+ if (source != null && !name.startsWith(source)) {
--- End diff --
I was originally thinking so but then I found out there are some other
components not specified as 'daemon' in DaemonType but also using metrics, such
as logviewer and RocksDB. I wasn't sure how to handle the case so internally I
convert them all to String. It's possible to register both with a Daemon and
with a name in String.
---
