[GitHub] storm pull request #2714: STORM-3101: Add filter to StormMetricsRegistry.

[zd-project]

Github user zd-project commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2714#discussion_r195467563
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
    @@ -73,6 +130,12 @@ private static void 
startMetricsReporter(PreparableReporter reporter, Map<String
         }
     
         private static <T extends Metric> T register(String name, T metric) {
    +        if (source != null && !name.startsWith(source)) {
    --- End diff --
    
    Thanks for the clarification. Anyone else also has suggestions in the 
implementation?


---