Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207328445
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void testMkFileFilterForLogCleanup() throws
IOException {
final long nowMillis = Time.currentTimeMillis();
final long cutoffMillis =
logCleaner.cleanupCutoffAgeMillis(nowMillis);
- final long oldMtimeMillis = cutoffMillis - 500;
- final long newMtimeMillis = cutoffMillis + 500;
+ final long interval = TimeUnit.MINUTES.toMillis(500);
--- End diff --
Not sure I follow. The cutoffMillis is calculated based on the 60 minutes,
so would be `now - 60 minutes`. It should be the same cutoffMillis used by the
log cleaner. 500 milliseconds before the cutoff is before the cutoff, right?
---
