Github user zd-project commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2787#discussion_r207329210
  
    --- Diff: 
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
 ---
    @@ -87,8 +88,9 @@ public void testMkFileFilterForLogCleanup() throws 
IOException {
     
             final long nowMillis = Time.currentTimeMillis();
             final long cutoffMillis = 
logCleaner.cleanupCutoffAgeMillis(nowMillis);
    -        final long oldMtimeMillis = cutoffMillis - 500;
    -        final long newMtimeMillis = cutoffMillis + 500;
    +        final long interval = TimeUnit.MINUTES.toMillis(500);
    --- End diff --
    
    Ah I missed that. My bad. You're right.


---

Reply via email to