Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207328980
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void testMkFileFilterForLogCleanup() throws
IOException {
final long nowMillis = Time.currentTimeMillis();
final long cutoffMillis =
logCleaner.cleanupCutoffAgeMillis(nowMillis);
- final long oldMtimeMillis = cutoffMillis - 500;
- final long newMtimeMillis = cutoffMillis + 500;
+ final long interval = TimeUnit.MINUTES.toMillis(500);
--- End diff --
Just to try to be a little more clear, the test needs a timestamp before
the cutoff, and a timestamp after the cutoff. The cutoff is `now - 60 minutes`.
`now - 60 minutes - 500 ms` is before the cutoff. I don't understand why it
instead needs to be `now - 60 minutes - 500 minutes`?
---
