[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209048376
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
 ---
    @@ -193,24 +198,23 @@ public Response logPage(String fileName, Integer 
start, Integer length, String g
                         throw e.getCause();
                     }
     
    -                List<String> filesStrWithoutFileParam = 
logFiles.stream().map(WorkerLogs::getTopologyPortWorkerLog)
    -                        .filter(fileStr -> !StringUtils.equals(fileName, 
fileStr)).collect(toList());
    -
    -                List<String> reorderedFilesStr = new ArrayList<>();
    -                reorderedFilesStr.addAll(filesStrWithoutFileParam);
    +                List<String> reorderedFilesStr = 
logFiles.stream().map(WorkerLogs::getTopologyPortWorkerLog)
    --- End diff --
    
    Nit: Put each step of the pipeline on a new line.


---