Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209071814
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
oldLogDirs.stream().map(File::getName).collect(joining(",")),
deadWorkerDirs.stream().map(File::getName).collect(joining(",")));
- deadWorkerDirs.forEach(Unchecked.consumer(dir -> {
+ for (File dir : deadWorkerDirs) {
String path = dir.getCanonicalPath();
- LOG.info("Cleaning up: Removing {}", path);
+ long size = FileUtils.sizeOf(dir);
--- End diff --
Rename to include the unit
---