[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209079798
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
 ---
    @@ -62,6 +64,14 @@
                 "logviewer:num-download-log-daemon-file-http-requests");
         private static final Meter meterListLogsHttpRequests = 
StormMetricsRegistry.registerMeter("logviewer:num-list-logs-http-requests");
     
    +    private static final Meter numSearchLogRequests = 
StormMetricsRegistry.registerMeter("logviewer:num-search-logs-requests");
    --- End diff --
    
    I see why it's useful to know how long they take, but is it useful to know 
how many searches have happened as well?


---