[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209078867
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
 ---
    @@ -71,6 +78,10 @@
     
     public class LogviewerLogSearchHandler {
         private static final Logger LOG = 
LoggerFactory.getLogger(LogviewerLogSearchHandler.class);
    +    private static final Meter numDeepSearchNoResult = 
StormMetricsRegistry.registerMeter("logviewer:num-deep-search-no-result");
    --- End diff --
    
    Are these metrics useful?


---