Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209087810
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of Logviewer.
*/
-public class LogviewerServer implements AutoCloseable {
+public class LogviewerServer implements AutoCloseable, MetricSet {
--- End diff --
No it would be `registerMetricSet(ExceptionMeters.[SOME_ENUM])` or
```java
enum ExceptionMeters implements MetricSet {
ENUM1;
private static final Map<...> map = ...;
public static MetricSet getMetricSet() {
return ENUM1;
@Override
public Map<...> getMetrics() {
return map;
}
}
```
---
