[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[zd-project]

Github user zd-project commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209096098
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
 ---
    @@ -235,7 +258,7 @@ FileFilter mkFileFilterForLogCleanup(long nowMillis) {
         private long lastModifiedTimeWorkerLogdir(File logDir) {
             long dirModified = logDir.lastModified();
     
    -        DirectoryStream<Path> dirStream = null;
    +        DirectoryStream<Path> dirStream;
             try {
                 dirStream = directoryCleaner.getStreamForDirectory(logDir);
    --- End diff --
    
    This is from the old working implementation. I wouldn't really change it 
unless it's 100% sure.


---