Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209096605
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package org.apache.storm.daemon.logviewer.utils;
+import com.codahale.metrics.ExponentiallyDecayingReservoir;
+import com.codahale.metrics.Histogram;
+
import java.io.File;
import java.io.IOException;
import javax.ws.rs.core.Response;
+import org.apache.storm.metric.StormMetricsRegistry;
+
+
public class LogFileDownloader {
+ private static final Histogram fileDownloadSizeDist =
StormMetricsRegistry.registerHistogram(
--- End diff --
It has the unit in name, so I don't think it's too confusing?
---
