Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2881#discussion_r226707791
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
 ---
    @@ -639,6 +639,10 @@ protected String javaCmd(String cmd) {
             }
     
             List<String> commandList = new ArrayList<>();
    +        if (numaId != null) {
    +            commandList.add("numactl");
    +            commandList.add("--i=" + numaId);
    +        }
    --- End diff --
    
    This is a Linux specific way of pinning a process to a numa zone, and it 
may not even be for all flavors of Linux.  We need a good way to turning this 
off for other systems, and ideally providing a way for them to override this if 
needed so things will work for them in the future.  It is okay to output a 
large warning if you are on an unsupported system.


---

Reply via email to