Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2881#discussion_r226707991
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
 ---
    @@ -820,8 +824,15 @@ private long calculateMemoryLimit(final 
WorkerResources resources, final int mem
         @Override
         public void launch() throws IOException {
             _type.assertFull();
    -        LOG.info("Launching worker with assignment {} for this supervisor 
{} on port {} with id {}", _assignment,
    -                 _supervisorId, _port, _workerId);
    +        String numaId = Utils.getNumaIdForPort(_port, _conf);
    +        if (numaId == null) {
    +            LOG.info("Launching worker with assignment {} for this 
supervisor {} on port {} with id {}", _assignment,
    +                    _supervisorId, _port, _workerId);
    +        } else {
    +            LOG.info("Launching worker with assignment {} for this 
supervisor {} on port {} with id {}" +
    +                            "bound to numa zone {}", _assignment,
    --- End diff --
    
    nit there is no space in between the {} above and the bound on this line.


---

Reply via email to