Github user govind-menon commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2881#discussion_r227413704
  
    --- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
    @@ -1041,6 +1041,19 @@
         @isPositiveNumber
         @NotNull
         public static final String SUPERVISOR_WORKER_TIMEOUT_SECS = 
"supervisor.worker.timeout.secs";
    +
    +    /**
    +     * A map with blobstore keys mapped to each NUMA Node on the 
supervisor that will be used
    +     * by scheduler. CPUs, memory and ports available on each NUMA node 
will be provided.
    +     * Each supervisor will have different map of NUMAs.
    +     * Example: "supervisor.numa.meta": { "Numas": [
    +     * {"Id": 0, "MemoryInMB": 122880, "Cores": [ 0, 12, 1, 13, 2, 14, 3, 
15, 4, 16, 5, 17],
    +     *  "Ports": [6700, 6701]},
    +     * {"Id": 1, "MemoryInMB": 122880, "Cores": [ 6, 18, 7, 19, 8, 20, 9, 
21, 10, 22, 11, 23],
    +     *  "Ports": [6702, 6703]}]}
    +     */
    +    public static final String SUPERVISOR_NUMA_META = 
"supervisor.numa.meta";
    --- End diff --
    
    There is verification that we do on reading the config that all the fields 
are present and exceptions that get thrown for invalid values.


---

Reply via email to