[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

[agresch]

Github user agresch commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2881#discussion_r228287958
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
 ---
    @@ -607,6 +608,27 @@ protected String javaCmd(String cmd) {
             return ret;
         }
     
    +    /**
    +     * Extracting out to mock it for tests.
    +     * @return true if on Linux.
    +     */
    +    protected boolean isOnLinux() {
    +        return SystemUtils.IS_OS_LINUX;
    +    }
    +
    +    private void addNumaPinningIfApplicable(String numaId, List<String> 
commandList) {
    +        if (numaId != null) {
    +            if (isOnLinux()) {
    +                commandList.add("numactl");
    +                commandList.add("--i=" + numaId);
    +                return;
    +            } else {
    +                // TODO : Add support for pinning on Windows host
    --- End diff --
    
    throw an exception?


---