[GitHub] storm pull request #2881: STORM-3259: NUMA Support for Storm

[Ethanlm]

Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2881#discussion_r228321712
  
    --- Diff: 
storm-server/src/test/java/org/apache/storm/daemon/supervisor/BasicContainerTest.java
 ---
    @@ -390,6 +398,116 @@ public void testLaunch() throws Exception {
                        "storm.log.dir", stormLogDir);
         }
     
    +    @Test
    +    public void testNumaPinnedLaunch() throws Exception {
    +        final String topoId = "test_topology_current";
    --- End diff --
    
    it doesn't matter but it seems to better have `topoId = 
"test_topology_numa_pinned";`


---