Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r227972886
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -119,15 +120,81 @@
// tests by subclassing.
private static Utils _instance = new Utils();
private static String memoizedLocalHostnameString = null;
- public static final Pattern TOPOLOGY_KEY_PATTERN =
Pattern.compile("^[\\w \\t\\._-]+$", Pattern.UNICODE_CHARACTER_CLASS);
+ public static final Pattern TOPOLOGY_KEY_PATTERN =
+ Pattern.compile("^[\\w \\t\\._-]+$",
Pattern.UNICODE_CHARACTER_CLASS);
+
+ public static final String NUMA_MEMORY_IN_MB = "memory.mb";
+ public static final String NUMA_CORES = "cores";
+ public static final String NUMAS_PORTS = "ports";
+ public static final String NUMA_ID = "node_id";
+ public static final String NUMAS_BASE = "numas";
--- End diff --
Let's make these names consistent. ("numa" vs. "numas").
Why don't the values here contain "numa"? I'd expect `NUMA_CORES =
"numa.cores"` or something like it.
---
