srdo commented on a change in pull request #3055: STORM-3440: client: fix all
checkstyle warnings
URL: https://github.com/apache/storm/pull/3055#discussion_r299121498
##########
File path:
storm-client/src/jvm/org/apache/storm/coordination/BatchBoltExecutor.java
##########
@@ -29,22 +29,22 @@
public class BatchBoltExecutor implements IRichBolt, FinishedCallback,
TimeoutCallback {
public static final Logger LOG =
LoggerFactory.getLogger(BatchBoltExecutor.class);
- byte[] _boltSer;
- Map<Object, IBatchBolt> _openTransactions;
- Map _conf;
- TopologyContext _context;
- BatchOutputCollectorImpl _collector;
+ byte[] boltSer;
Review comment:
Can we make these private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
