srdo commented on a change in pull request #3055: STORM-3440: client: fix all
checkstyle warnings
URL: https://github.com/apache/storm/pull/3055#discussion_r299124437
##########
File path: storm-client/src/jvm/org/apache/storm/drpc/DRPCSpout.java
##########
@@ -49,38 +49,39 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+@SuppressWarnings("checkstyle:AbbreviationAsWordInName")
public class DRPCSpout extends BaseRichSpout {
public static final Logger LOG = LoggerFactory.getLogger(DRPCSpout.class);
//ANY CHANGE TO THIS CODE MUST BE SERIALIZABLE COMPATIBLE OR THERE WILL BE
PROBLEMS
static final long serialVersionUID = 2387848310969237877L;
- final String _function;
- final String _local_drpc_id;
- SpoutOutputCollector _collector;
- List<DRPCInvocationsClient> _clients = new ArrayList<>();
- transient LinkedList<Future<Void>> _futures = null;
- transient ExecutorService _backround = null;
+ final String function;
+ final String localDrpcId;
+ SpoutOutputCollector collector;
+ List<DRPCInvocationsClient> clients = new ArrayList<>();
+ transient LinkedList<Future<Void>> futures = null;
+ transient ExecutorService backround = null;
public DRPCSpout(String function) {
- _function = function;
+ this.function = function;
if (DRPCClient.isLocalOverride()) {
- _local_drpc_id = DRPCClient.getOverrideServiceId();
+ localDrpcId = DRPCClient.getOverrideServiceId();
} else {
- _local_drpc_id = null;
+ localDrpcId = null;
}
}
public DRPCSpout(String function, ILocalDRPC drpc) {
- _function = function;
- _local_drpc_id = drpc.getServiceId();
+ this.function = function;
+ localDrpcId = drpc.getServiceId();
}
- public String get_function() {
- return _function;
+ public String getFunction() {
Review comment:
I think we need to suppress this, it's part of the API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
