srdo commented on a change in pull request #3055: STORM-3440: client: fix all
checkstyle warnings
URL: https://github.com/apache/storm/pull/3055#discussion_r299126033
##########
File path: storm-client/src/jvm/org/apache/storm/messaging/netty/Login.java
##########
@@ -40,19 +40,21 @@
// and try to renew the ticket.
private static final float TICKET_RENEW_WINDOW = 0.80f;
/**
- * Percentage of random jitter added to the renewal time
+ * Percentage of random jitter added to the renewal time.
*/
private static final float TICKET_RENEW_JITTER = 0.05f;
// Regardless of TICKET_RENEW_WINDOW setting above and the ticket expiry
time,
// thread will not sleep between refresh attempts any less than 1 minute
(60*1000 milliseconds = 1 minute).
// Change the '1' to e.g. 5, to change this to 5 minutes.
private static final long MIN_TIME_BEFORE_RELOGIN = 1 * 60 * 1000L;
- /** Random number generator */
+ /**
+ * Random number generator.
+ */
private static Random rng = new Random();
public CallbackHandler callbackHandler;
- Logger LOG = Logger.getLogger(Login.class);
+ static final Logger LOG = Logger.getLogger(Login.class);
Review comment:
Nit: Make private
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
