srdo commented on a change in pull request #3055: STORM-3440: client: fix all
checkstyle warnings
URL: https://github.com/apache/storm/pull/3055#discussion_r299121066
##########
File path:
storm-client/src/jvm/org/apache/storm/coordination/CoordinatedBolt.java
##########
@@ -107,61 +107,61 @@ private boolean checkFinishId(Tuple tup, TupleType type)
{
Object id = tup.getValue(0);
boolean failed = false;
- synchronized (_tracked) {
- TrackingInfo track = _tracked.get(id);
+ synchronized (tracked) {
+ TrackingInfo track = tracked.get(id);
try {
if (track != null) {
boolean delayed = false;
- if (_idStreamSpec == null && type == TupleType.COORD ||
_idStreamSpec != null && type == TupleType.ID) {
+ if (idStreamSpec == null && type == TupleType.COORD ||
idStreamSpec != null && type == TupleType.ID) {
track.ackTuples.add(tup);
delayed = true;
}
if (track.failed) {
failed = true;
for (Tuple t : track.ackTuples) {
- _collector.fail(t);
+ collector.fail(t);
}
- _tracked.remove(id);
+ tracked.remove(id);
} else if (track.receivedId
- && (_sourceArgs.isEmpty() ||
- track.reportCount == _numSourceReports &&
- track.expectedTupleCount ==
track.receivedTuples)) {
- if (_delegate instanceof FinishedCallback) {
- ((FinishedCallback) _delegate).finishedId(id);
+ && (sourceArgs.isEmpty()
+ || track.reportCount == numSourceReports
+ && track.expectedTupleCount ==
track.receivedTuples)) {
Review comment:
I think this should be indented at the same level as the line above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
