srdo commented on issue #3084: STORM-3425: Add module UnusedImports to checkstyle configuration URL: https://github.com/apache/storm/pull/3084#issuecomment-509023993 I don't have a strong opinion on this, I'd just like to avoid checkstyle becoming too much of a hassle for contributors. I've seen other projects go what I would consider overboard with checks that I don't think contribute much to code quality (e.g. checking for whitespace in empty lines), and it adds a bunch of busywork when making a contribution. I'm not against trying this. We can always remove the check again if it turns out to be annoying. You will need to fix any violations before we can merge this though. By the way, I missed this in your earlier PR to remove JavadocMethod, but please update the comment here https://github.com/apache/storm/blob/master/storm-checkstyle/src/main/resources/storm/storm_checkstyle.xml#L28. Otherwise we will probably accidentally overwrite your changes next time we update Checkstyle.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
