srdo commented on issue #3084: STORM-3425: Add module UnusedImports to checkstyle configuration URL: https://github.com/apache/storm/pull/3084#issuecomment-509026930 Regarding what should be changed: We need to put an extra line at https://github.com/apache/storm/blob/master/storm-checkstyle/src/main/resources/storm/storm_checkstyle.xml#L28 telling the reader that we've removed the JavadocMethod rule. It's meant as a help for the person updating checkstyle in Storm, so it's obvious to them what they need to change in google_checks.xml to get the new version of storm_checkstyle.xml.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
