srdo commented on issue #3084: STORM-3425: Add module UnusedImports to checkstyle configuration URL: https://github.com/apache/storm/pull/3084#issuecomment-509026691 When we update the Checkstyle version, we need to also update the storm_checkstyle.xml. Storm_checkstyle.xml is based on google_checkstyle.xml, and makes a few adjustments to that file. When Checkstyle publishes a new version of Checkstyle, they also publish a new google_checks.xml. This means that when Storm updates to a new Checkstyle version, we go and get the new google_checks.xml, and overwrite the storm_checkstyle.xml. We then make the couple of modifications to it that are outlined in the comment I linked. This is obviously an error prone and bad way of making such adjustments, but Checkstyle currently doesn't support extending/overriding existing check files, so we have to get the full google_checks.xml and adjust it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
