kishorvpatil commented on a change in pull request #3213: [STORM-3588] add 
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource 
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r387630064
 
 

 ##########
 File path: 
storm-server/src/main/java/org/apache/storm/scheduler/ISchedulingState.java
 ##########
 @@ -271,6 +273,13 @@ boolean wouldFit(
      */
     double getClusterTotalMemoryResource();
 
+    /**
+     * Get the total amount of generic resources (excluding CPU and memory) in 
cluster.
+     */
+    default Map<String, Double> getClusterTotalGenericResource() {
 
 Review comment:
   Method name should probably be `getClusterTotalGenericResources`  with s

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to