kishorvpatil commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r387632643
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/ISchedulingState.java
##########
@@ -271,6 +273,13 @@ boolean wouldFit(
*/
double getClusterTotalMemoryResource();
+ /**
+ * Get the total amount of generic resources (excluding CPU and memory) in
cluster.
+ */
+ default Map<String, Double> getClusterTotalGenericResource() {
Review comment:
Cluster should have a private variable that avoids recalculating this often.
Similarly, it should have Set<String> genericResourceTypes.
And method `getClusterGenericResourceTypes`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
