kishorvpatil commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r393152100
##########
File path: storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java
##########
@@ -80,6 +80,13 @@
private final Map<String, Map<String, Double>>
nodeToScheduledOffHeapNodeMemoryCache; // node -> topologyId -> double
private final Map<String, Set<WorkerSlot>> nodeToUsedSlotsCache;
private final Map<String, NormalizedResourceRequest>
totalResourcesPerNodeCache = new HashMap<>();
+ /**
+ * Snapshot of cluster total resources (cpu, memory, generic).
+ */
+ private final double totalCpuResource;
+ private final double totalMemoryResource;
+ private final Map<String, Double> totalGenericResources;
Review comment:
These three variables nee to be part if copying from src in copy constructor
and `public Cluster(Cluster src, Topologies topologies)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
