Ethanlm commented on a change in pull request #3243: [STORM-3616] add optional
flag to fail upload-credentials cmd if no creds were uploaded
URL: https://github.com/apache/storm/pull/3243#discussion_r402327646
##########
File path: storm-client/src/jvm/org/apache/storm/StormSubmitter.java
##########
@@ -126,7 +127,7 @@ public static void pushCredentials(String name,
Map<String, Object> topoConf, Ma
* @throws NotAliveException if the topology is not alive
* @throws InvalidTopologyException if any other error happens
*/
- public static void pushCredentials(String name, Map<String, Object>
topoConf, Map<String, String> credentials, String expectedUser)
+ public static boolean pushCredentials(String name, Map<String, Object>
topoConf, Map<String, String> credentials, String expectedUser)
Review comment:
missing javadoc `@return`
There is another `pushCredentials` method in this class needs to be taken
care of
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
