Ethanlm commented on a change in pull request #3243: [STORM-3616] add optional
flag to fail upload-credentials cmd if no creds were uploaded
URL: https://github.com/apache/storm/pull/3243#discussion_r402560113
##########
File path: bin/storm.py
##########
@@ -541,6 +541,13 @@ def initialize_upload_credentials_subcommand(subparsers):
help="""name of the owner of the topology (security precaution)"""
)
+ # If set, this flag will become true meaning that user expects non-empty
creds to be uploaded.
+ # Command exits with non-zero code if uploaded creds collection is empty.
+ sub_parser.add_argument(
+ "-e", "--exception", action='store_true',
Review comment:
This is also good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
