Ethanlm commented on a change in pull request #3243: [STORM-3616] add optional
flag to fail upload-credentials cmd if no creds were uploaded
URL: https://github.com/apache/storm/pull/3243#discussion_r402329623
##########
File path: storm-core/src/jvm/org/apache/storm/command/UploadCredentials.java
##########
@@ -111,7 +112,13 @@ public static void main(String[] args) throws Exception {
// use the local setting for the login config rather than the
topology's
topologyConf.remove("java.security.auth.login.config");
- StormSubmitter.pushCredentials(topologyName, topologyConf,
credentialsMap, (String) cl.get("u"));
+ boolean throwExceptionForEmptyCreds = (boolean) cl.getOrDefault("e",
false);
Review comment:
No need for default value here. above `boolOpt` is already default to `false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
