RuiLi8080 commented on a change in pull request #3243: [STORM-3616] add
optional flag to fail upload-credentials cmd if no creds were uploaded
URL: https://github.com/apache/storm/pull/3243#discussion_r403064825
##########
File path: bin/storm.py
##########
@@ -541,6 +541,13 @@ def initialize_upload_credentials_subcommand(subparsers):
help="""name of the owner of the topology (security precaution)"""
)
+ # If set, this flag will become true meaning that user expects non-empty
creds to be uploaded.
+ # Command exits with non-zero code if uploaded creds collection is empty.
+ sub_parser.add_argument(
+ "-e", "--exception-when-empty", action='store_true',
+ help="""whether to throw exception if there are no credentials
uploaded, default to be false"""
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
