Ethanlm commented on a change in pull request #3243: [STORM-3616] add optional
flag to fail upload-credentials cmd if no creds were uploaded
URL: https://github.com/apache/storm/pull/3243#discussion_r402566760
##########
File path: storm-client/src/jvm/org/apache/storm/StormSubmitter.java
##########
@@ -106,27 +106,30 @@ public static boolean validateZKDigestPayload(String
payload) {
* @param name the name of the topology to push credentials to.
* @param topoConf the topology-specific configuration, if desired. See
{@link Config}.
* @param credentials the credentials to push.
+ * @return whether the pushed credential collection fullCreds is
non-empty. Return false if empty.
Review comment:
`fullCreds` doesn't really mean anything, image anyone changed the variable
name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
