bipinprasad commented on a change in pull request #3237: STORM-3259: Adds NUMA
awareness to enable worker pinning
URL: https://github.com/apache/storm/pull/3237#discussion_r405091436
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
##########
@@ -87,12 +153,16 @@ private SupervisorInfo buildSupervisorInfo(Map<String,
Object> conf, Supervisor
ret.put(stringNumberEntry.getKey(),
stringNumberEntry.getValue().doubleValue());
}
+
LOG.debug(NormalizedResources.RESOURCE_NAME_NORMALIZER.normalizedResourceMap(ret).toString());
return
NormalizedResources.RESOURCE_NAME_NORMALIZER.normalizedResourceMap(ret);
}
@Override
public void run() {
- SupervisorInfo supervisorInfo = buildSupervisorInfo(conf, supervisor);
- stormClusterState.supervisorHeartbeat(supervisorId, supervisorInfo);
+ Map<String, Object> validatedNumaMap = Utils.getNumaMap(conf);
Review comment:
I think line should be pulled into buildSupervisorInfo(). It appears that
the intent is to create as many supervisorInfo records as there are
Config.SUPERVISOR_NUMA_META entries with any leftover creating another
SupervisorInfo(). And private buildSupervisorInfo() method is never called with
validatedNumaMap of null. Each of these supervisorInfos creating a heartbeat-er.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
