govind-menon commented on a change in pull request #3237: STORM-3259: Adds NUMA
awareness to enable worker pinning
URL: https://github.com/apache/storm/pull/3237#discussion_r406264259
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
##########
@@ -87,12 +153,16 @@ private SupervisorInfo buildSupervisorInfo(Map<String,
Object> conf, Supervisor
ret.put(stringNumberEntry.getKey(),
stringNumberEntry.getValue().doubleValue());
}
+
LOG.debug(NormalizedResources.RESOURCE_NAME_NORMALIZER.normalizedResourceMap(ret).toString());
return
NormalizedResources.RESOURCE_NAME_NORMALIZER.normalizedResourceMap(ret);
}
@Override
public void run() {
- SupervisorInfo supervisorInfo = buildSupervisorInfo(conf, supervisor);
- stormClusterState.supervisorHeartbeat(supervisorId, supervisorInfo);
+ Map<String, Object> validatedNumaMap = Utils.getNumaMap(conf);
Review comment:
The supervisor info does one thing - it creates an object with information
about the actual supervisor. I think it's better to not add something like the
NUMA heartbeating to its purview.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
