Ethanlm commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r405255219
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
##########
@@ -239,6 +246,10 @@ private void scheduleTopology(TopologyDetails td, Cluster
cluster, final User to
markFailedTopology(topologySubmitter, cluster, td, "Failed to schedule
within " + maxSchedulingAttempts + " attempts");
}
+ public Set<String> getEvictedTopologies() {
Review comment:
Yes that's right. We should return a unmodifiableCollection to solve the
race condition. I think my question is mostly on how do we want to use this
`evictedTopologies` information in regular code except unit test since it's
only a snapshot of all the `evictedTopologies` at the moment we call
`getEvictedTopologies`. And it could be evictedTopologies after scheduling
multiple topologies. And this information is not very useful.
If we want to log what are evicted when scheduling a certain topology, we
can change the above line to `LOG.info` and it works better than having a
`evictedTopologies` list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
