Ethanlm commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r406823545
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/priority/TestGenericResourceAwareSchedulingPriorityStrategy.java
##########
@@ -210,4 +216,11 @@ private Cluster mkTestCluster(Topologies topologies,
Config config) {
return new Cluster(iNimbus, new ResourceMetrics(new
StormMetricsRegistry()), supMap, new HashMap<>(), topologies, config);
}
+
+ private Set<String> collectMapValues(Map<String, Set<String>> map) {
+ return map.values()
Review comment:
This looks overly complicated.
```
Set<String> set = new HashSet<>();
map.values().forEach((s) -> set.addAll(s));
return set;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
