Ethanlm commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r406827570
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
##########
@@ -115,6 +122,7 @@ public void schedule(Topologies topologies, Cluster
cluster) {
scheduleTopology(td, cluster, submitter, orderedTopologies);
}
}
+ evictedTopologiesMap = tmpEvictedTopologiesMap;
Review comment:
The idea of making `evictedTopologiesMap` a result after a complete schedule
round is a good idea.
But the code here makes `evictedTopologiesMap` and `tmpEvictedTopologiesMap`
the same object.
So tmpEvictedTopologiesMap.clear == evictedTopologiesMap.clear. This won't
achieve the goal here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
