Ethanlm commented on a change in pull request #3322:
URL: https://github.com/apache/storm/pull/3322#discussion_r482116135
##########
File path: storm-client/src/jvm/org/apache/storm/StormSubmitter.java
##########
@@ -235,7 +237,14 @@ public static void submitTopologyAs(String name,
Map<String, Object> topoConf, S
conf.putAll(topoConf);
topoConf.putAll(prepareZookeeperAuthentication(conf));
- validateConfs(conf, topology, name);
+ validateConfs(conf);
+
+ try {
+ StormCommon.validateCycleFree(topology, name);
+ } catch (InvalidTopologyException ex) {
+ LOG.warn(ex.get_msg(), ex);
+ System.out.println(ex.get_msg());
Review comment:
We should remove this
##########
File path: storm-client/src/jvm/org/apache/storm/StormSubmitter.java
##########
@@ -51,6 +52,7 @@
import org.apache.storm.validation.ConfigValidation;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import sun.net.ProgressListener;
Review comment:
Is this used anywhere?
##########
File path: storm-client/src/jvm/org/apache/storm/StormSubmitter.java
##########
@@ -235,7 +237,14 @@ public static void submitTopologyAs(String name,
Map<String, Object> topoConf, S
conf.putAll(topoConf);
topoConf.putAll(prepareZookeeperAuthentication(conf));
- validateConfs(conf, topology, name);
+ validateConfs(conf);
+
+ try {
+ StormCommon.validateCycleFree(topology, name);
+ } catch (InvalidTopologyException ex) {
+ LOG.warn(ex.get_msg(), ex);
Review comment:
Will `ex` already contains `ex.get_msg()`? If so, we will see repeating
messages, which should be avoid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
