Ethanlm commented on a change in pull request #3322:
URL: https://github.com/apache/storm/pull/3322#discussion_r482121654
##########
File path: storm-client/src/jvm/org/apache/storm/StormSubmitter.java
##########
@@ -233,7 +235,7 @@ public static void submitTopologyAs(String name,
Map<String, Object> topoConf, S
conf.putAll(topoConf);
topoConf.putAll(prepareZookeeperAuthentication(conf));
- validateConfs(conf, topology);
+ validateConfs(conf, topology, name);
Review comment:
Moving it to Utils is also okay, like
`Utils.validateTopologyBlobStoreMap`
`Utils.validateTopologyName`
etc.
Probably makes more sense since `findComponentCycles` is implemented inside
Utils.
And we could make `Utils.findComponentCycles` "@VisibleForTesting". So the
public method will be only `Utils. validateCycleFree` and the internal
implementation can be changed if we'd like in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
