bipinprasad commented on a change in pull request #3322:
URL: https://github.com/apache/storm/pull/3322#discussion_r482261702
##########
File path: storm-client/src/jvm/org/apache/storm/StormSubmitter.java
##########
@@ -235,7 +237,14 @@ public static void submitTopologyAs(String name,
Map<String, Object> topoConf, S
conf.putAll(topoConf);
topoConf.putAll(prepareZookeeperAuthentication(conf));
- validateConfs(conf, topology, name);
+ validateConfs(conf);
+
+ try {
+ StormCommon.validateCycleFree(topology, name);
+ } catch (InvalidTopologyException ex) {
+ LOG.warn(ex.get_msg(), ex);
Review comment:
InvalidTopologyException constructor does not call Exception.super(msg):
https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/generated/InvalidTopologyException.java#L111
hence, its msg variable is not available in the Exception.getMessage()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
