bipinprasad commented on a change in pull request #3366:
URL: https://github.com/apache/storm/pull/3366#discussion_r547663782
##########
File path:
storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
##########
@@ -61,10 +61,15 @@ static boolean doRequiredTopoFilesExist(Map<String, Object>
conf, String stormId
}
public static int processLauncherAndWait(Map<String, Object> conf, String
user, List<String> args,
- final Map<String, String>
environment, final String logPreFix)
+ final Map<String, String>
environment, final String logPreFix) throws IOException {
Review comment:
does this "final" do anything here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
