bipinprasad commented on a change in pull request #3366:
URL: https://github.com/apache/storm/pull/3366#discussion_r548505766
##########
File path: storm-core/src/native/worker-launcher/impl/main.c
##########
@@ -269,6 +274,45 @@ int main(int argc, char **argv) {
return INVALID_ARGUMENT_NUMBER;
}
exit_code = signal_container_as_user(user_detail->pw_name, container_pid,
signal);
+ } else if (strcasecmp("run-oci-container", command) == 0) {
+ if (argc != 6) {
+ fprintf(ERRORFILE, "Incorrect number of arguments (%d vs 6) for
run-oci-container\n", argc);
+ fflush(ERRORFILE);
+ return INVALID_ARGUMENT_NUMBER;
Review comment:
nit: log and error files are closed before return for most cases. set
exit_code here also?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
